wait for tenant to be active before polling for timeline absence #4856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1240 tests run: 1189 passed, 0 failed, 51 skipped (full report) |
koivunej
reviewed
Jul 31, 2023
koivunej
approved these changes
Jul 31, 2023
LizardWizzard
force-pushed
the
dkr/timeline-delete-flaky
branch
from
039fce1 to
f0d10d9
Compare
Re-running. |
|
Re: timeouts, adding this one here as well: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-4857/5718388045/index.html#suites/f588e0a787c49e67b29490359c589fae/5ef37c7fda6cfb7f TL;DR: another tenant load not completing in 2s, this time aiming for Broken. I think we should raise all timeouts to 10 seconds on tests which are also ran against real_s3. |
|
I'll rerun workflow for several times to be sure that the fix helped |
koivunej
reviewed
Aug 1, 2023
LizardWizzard
force-pushed
the
dkr/timeline-delete-flaky
branch
from
0b640b1 to
66d8577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://neon-github-public-dev.s3.amazonaws.com/reports/main/5692829577/index.html#suites/f588e0a787c49e67b29490359c589fae/4c50937643d68a66
Summary of changes
wait for tenant to be active after restart before polling for timeline absence