Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagectl: skip metadata file in pagectl draw-timeline #4872

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Aug 2, 2023

Problem

Running pagectl draw-timeline on a pageserver directory wasn't working out of the box because it trips up on the metadata file.

Summary of changes

Just ignore the metadata file in the list of input files passed to draw-timeline.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Otherwise it panics trying to parse it.
@jcsp jcsp added c/storage/pageserver Component: storage: pageserver a/tech_debt Area: related to tech debt labels Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

1264 tests run: 1215 passed, 0 failed, 49 skipped (full report)


@jcsp
Copy link
Collaborator Author

jcsp commented Aug 2, 2023

e2e tests failed with a connection error to docker.io

@jcsp jcsp marked this pull request as ready for review August 2, 2023 18:27
@jcsp jcsp requested review from a team as code owners August 2, 2023 18:27
@jcsp jcsp requested review from fprasx and hlinnaka and removed request for a team August 2, 2023 18:27
@jcsp jcsp merged commit 64a4fb3 into main Aug 7, 2023
@jcsp jcsp deleted the jcsp/draw-timeline-fix branch August 7, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants