Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_runner: set AWS credentials for endpoints #4887

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Aug 3, 2023

Problem

If AWS credentials are not set locally (via AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY env vars) test_remote_library[release-pg15-mock_s3] test fails with the following error:

ERROR could not start the compute node: Failed to download a remote file: Failed to download S3 object: failed to construct request

Summary of changes

  • set AWS credentials for endpoints programmatically

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin requested review from jcsp and awestover August 3, 2023 11:58
Copy link
Contributor

@awestover awestover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@awestover awestover self-requested a review August 3, 2023 12:04
Copy link
Contributor

@awestover awestover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@bayandin bayandin enabled auto-merge (squash) August 3, 2023 12:12
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

1264 tests run: 1215 passed, 0 failed, 49 skipped (full report)


Flaky tests (3)

Postgres 14

  • test_partial_evict_tenant: debug
  • test_multiple_extensions_one_archive: release
  • test_empty_tenant_size: debug

@bayandin bayandin merged commit cd33089 into main Aug 3, 2023
@bayandin bayandin deleted the bayandin/fix-test_remote_library-local branch August 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants