pageserver: expose prometheus metrics for startup time #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
c/storage/pageserver
These are broken down by phase, where the phases correspond to the existing wait points in the code: - Start of doing I/O - When tenant load is done - When initial size calculation is done - When background jobs start - Then "complete" when everything is done.
jcsp
force-pushed
the
jcsp/startup_metrics
branch
from
0941b21 to
6707d58
Compare
koivunej
reviewed
Aug 3, 2023
1264 tests run: 1214 passed, 0 failed, 50 skipped (full report) |
|
We should add these metrics to ... list of global metrics somewhere in the python regress suite. Those tests are quite the mess, we assert metrics in two different files and there are easy failures, but a global metric is not bad. I will have to do the same for #4892. Feel free to look into #4813 as well. I'll link this to some observability epic. |
|
Adding a time to activate as in #4083 was requested might be a good next step on a separate PR. |
chronologically equivalent currently, but more future-proof to put it here.
jcsp
force-pushed
the
jcsp/startup_metrics
branch
from
f83db0a to
31c0731
Compare
koivunej
reviewed
Aug 4, 2023
koivunej
reviewed
Aug 4, 2023
koivunej
reviewed
Aug 4, 2023
This reverts commit 4798976.
koivunej
reviewed
Aug 8, 2023
koivunej
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Follow-up include more stuff to do on #4813, otherwise this is looking good now. We don't have cancellation safety for these metrics, but I cannot image in which sitation we'd need them, because we are then doing a restart faster than what is the scraping delay.
Co-authored-by: Joonas Koivunen <joonas@neon.tech>
jcsp
requested review from
conradludgate and
problame
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently to know how long pageserver startup took requires inspecting logs.
Summary of changes
pageserver_startup_duration_msmetric is added, with labelphasefor different phases of startup.These are broken down by phase, where the phases correspond to the existing wait points in the code:
Checklist before requesting a review
Checklist before merging