Explain why VirtualFile stores tenant_id and timeline_id as strings #4930
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
One might wonder why the code here doesn't use
TimelineId
orTenantId
. I originally had a refactor to use them, but then discarded it, because converting to strings on each time there is a read or write is wasteful.Summary of changes
We add some docs explaining why here no
TimelineId
orTenantId
is being used.Checklist before requesting a review
Checklist before merging