Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain why VirtualFile stores tenant_id and timeline_id as strings #4930

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Aug 8, 2023

Problem

One might wonder why the code here doesn't use TimelineId or TenantId. I originally had a refactor to use them, but then discarded it, because converting to strings on each time there is a read or write is wasteful.

Summary of changes

We add some docs explaining why here no TimelineId or TenantId is being used.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@arpad-m arpad-m requested review from a team as code owners August 8, 2023 15:55
@arpad-m arpad-m requested review from save-buffer and skyzh and removed request for a team August 8, 2023 15:55
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

1264 tests run: 1211 passed, 0 failed, 53 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug

@arpad-m arpad-m merged commit 1037a8d into main Aug 8, 2023
@arpad-m arpad-m deleted the arpad/virtual_file_id branch August 8, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants