Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant BypassRLS to new neon_superuser roles #4935

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

save-buffer
Copy link
Contributor

@save-buffer save-buffer commented Aug 9, 2023

Problem

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@save-buffer save-buffer requested a review from a team as a code owner August 9, 2023 01:31
@save-buffer save-buffer requested review from ololobus and removed request for a team August 9, 2023 01:31
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

1264 tests run: 1209 passed, 0 failed, 55 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_crafted_wal_end[last_wal_record_xlog_switch_ends_on_page_boundary]: debug
The comment gets automatically updated with the latest test results
f077171 at 2023-08-09T10:03:36.500Z :recycle:

@vadim2404 vadim2404 merged commit 3a71cf3 into main Aug 10, 2023
@vadim2404 vadim2404 deleted the sasha_bypassrls branch August 10, 2023 19:04
@ololobus
Copy link
Member

@save-buffer any comments, why we need this? Comments in code would be nice too

@save-buffer
Copy link
Contributor Author

I guess just to emulate superuser as closely as possible. User asked for it, so we added it, not really sure what else to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants