Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: http logging to 11 #4950

Merged
merged 4 commits into from
Aug 10, 2023
Merged

proxy: http logging to 11 #4950

merged 4 commits into from
Aug 10, 2023

Conversation

conradludgate
Copy link
Contributor

Problem

Mysterious network issues

Summary of changes

Log a lot more about HTTP/DNS in hopes of detecting more of the network errors

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@conradludgate conradludgate requested a review from a team as a code owner August 10, 2023 10:14
@conradludgate conradludgate requested review from Daniel-ef, skyzh and petuhovskiy and removed request for a team August 10, 2023 10:14
@conradludgate conradludgate enabled auto-merge (squash) August 10, 2023 10:22
@github-actions
Copy link

github-actions bot commented Aug 10, 2023

1584 tests run: 1509 passed, 0 failed, 75 skipped (full report)


The comment gets automatically updated with the latest test results
f4c797a at 2023-08-10T16:21:25.310Z :recycle:

@conradludgate conradludgate disabled auto-merge August 10, 2023 10:57
@conradludgate conradludgate enabled auto-merge (squash) August 10, 2023 11:03
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but would it be a better idea to record tracing spans instead of logging? As we can have hierarchy in tracing, and also the exact start / end timestamp that makes it easier to search. To reduce the amount of tracing data, we can also do something that only reports slow requests so as to reduce the pressure on the metrics / log server.

proxy/src/console/provider/neon.rs Outdated Show resolved Hide resolved
@conradludgate
Copy link
Contributor Author

but would it be a better idea to record tracing spans instead of logging

Yes, I would love that eventually

@conradludgate conradludgate merged commit 25c66dc into main Aug 10, 2023
@conradludgate conradludgate deleted the proxy/log-network-durations branch August 10, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants