Changed batch query body to from [...] to { queries: [...] } #4975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's nice if
single query : single response :: batch query : batch response
.But at present, in the single case we send
{ query: '', params: [] }
and get back a single{ rows: [], ... }
object, while in the batch case we send an array of{ query: '', params: [] }
objects and get back not an array of{ rows: [], ... }
objects but a{ results: [ { rows: [] , ... }, { rows: [] , ... }, ... ] }
object instead.Summary of changes
With this change, the batch query body becomes
{ queries: [{ query: '', params: [] }, ... ] }
, which restores a consistent relationship between the request and response bodies.Checklist before requesting a review
Checklist before merging