Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump vm-builder version to v0.15.4 #4980

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

fprasx
Copy link
Contributor

@fprasx fprasx commented Aug 11, 2023

Problem

Summary of changes

Patches a bug in vm-builder where it did not include enough parameters in the query string. These parameters are host=localhost port=5432. These parameters were not necessary for the monitor because the pq go postgres driver included them by default.

New computes should now have working monitors due to it now being able to connect to the postgres file cache.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@fprasx fprasx requested a review from sharnoff August 11, 2023 17:09
Copy link
Member

@sharnoff sharnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description should describe the changes from v0.15.0-alpha1 to v0.15.4, and give some motivation as to why upgrade, but otherwise lgtm.

@github-actions
Copy link

1584 tests run: 1506 passed, 0 failed, 78 skipped (full report)


The comment gets automatically updated with the latest test results
7d15334 at 2023-08-11T17:29:31.168Z :recycle:

@fprasx fprasx merged commit cc2d00f into main Aug 11, 2023
@fprasx fprasx deleted the fprasx/bump-vm-builder-version branch August 11, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants