Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deferrable transaction option to http batch queries #4993

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

jawj
Copy link
Contributor

@jawj jawj commented Aug 15, 2023

Problem

HTTP batch queries currently allow us to set the isolation level and read only, but not deferrable.

Summary of changes

Add support for deferrable.

Also, stop echoing read-only status in response headers unless true. Likewise only echo deferrable status in response headers if true.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

1588 tests run: 1513 passed, 0 failed, 75 skipped (full report)


The comment gets automatically updated with the latest test results
73b9d7e at 2023-08-15T13:12:19.152Z :recycle:

@jawj jawj marked this pull request as ready for review August 15, 2023 13:44
@jawj jawj requested a review from a team as a code owner August 15, 2023 13:44
@jawj jawj requested review from NanoBjorn and conradludgate and removed request for a team August 15, 2023 13:44
@jawj jawj merged commit 218be9e into main Aug 15, 2023
@jawj jawj deleted the jawj/http-batch-deferrable branch August 15, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants