Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Before, DeltaLayer dumping (via
cargo run --release -p pagectl -- print-layer-file
) would crash as one can't callHandle::block_on
in an async executor thread.Summary of changes
Avoid the problem by using
DeltaLayerInner::load_keys
to load the keys into RAM (which we already do during compaction), and then load the values one by one during dumping.Checklist before requesting a review
Checklist before merging