fix: remove layer_removal_cs #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
requested review from
fprasx and
skyzh
and removed request for
a team
2394 tests run: 2300 passed, 0 failed, 94 skipped (full report)Flaky tests (3)Postgres 16
Postgres 15Code coverage (full report)
The comment gets automatically updated with the latest test results
9d02ac4 at 2023-11-28T15:56:47.253Z :recycle: |
koivunej
force-pushed
the
remove_remote_layer_ongoing
branch
from
ac3e08a to
53eacac
Compare
koivunej
force-pushed
the
remove_remote_layer_ongoing
branch
2 times, most recently
from
3215f39 to
38f556a
Compare
koivunej
force-pushed
the
remove_remote_layer_ongoing
branch
2 times, most recently
from
0820b61 to
5fd7d84
Compare
koivunej
force-pushed
the
post_remove_remote_layer_ongoing
branch
from
a94b446 to
e267607
Compare
koivunej
commented
Oct 26, 2023
jcsp
reviewed
Oct 26, 2023
koivunej
force-pushed
the
post_remove_remote_layer_ongoing
branch
2 times, most recently
from
722411a to
db75a29
Compare
|
After fixing the RemoteTimelineClient at least hastily, the scrubber seems to cause errors for any unlinked file? |
koivunej
force-pushed
the
post_remove_remote_layer_ongoing
branch
3 times, most recently
from
966d4fb to
cb67e18
Compare
koivunej
changed the title
koivunej
commented
Nov 10, 2023
to be fixed for the metrics soon.
koivunej
force-pushed
the
post_remove_remote_layer_ongoing
branch
from
ef5aec4 to
512ba3e
Compare
Co-authored-by: Christian Schwarz <christian@neon.tech>
i did not realize it prompts review of callsites; also move the scopeguard to the top to raise less questions.
to understand which tests fail.
koivunej
force-pushed
the
post_remove_remote_layer_ongoing
branch
from
512ba3e to
9d02ac4
Compare
Looks flaky but unsure why. Re-ran. |
koivunej
added a commit
that referenced
this pull request
Dec 7, 2023
Per [feedback], split the Layer metrics, also finally account for lost and [re-submitted feedback] on `layer_gc` by renaming it to `layer_delete`, `Layer::garbage_collect_on_drop` renamed to `Layer::delete_on_drop`. References to "gc" dropped from metric names and elsewhere. Also fixes how the cancellations were tracked: there was one rare counter. Now there is a top level metric for cancelled inits, and the rare "download failed but failed to communicate" counter is kept. Fixes: #6027 [feedback]: #5809 (review) [re-submitted feedback]: #5108 (comment)
koivunej
added a commit
that referenced
this pull request
Dec 13, 2023
We no longer have `layer_removal_cs` since #5108, we no longer need batching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quest: #4745. Follow-up to #4938.