Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2023-08-25 #5113

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Release 2023-08-25 #5113

merged 2 commits into from
Aug 25, 2023

Conversation

conradludgate
Copy link
Contributor

@conradludgate conradludgate commented Aug 25, 2023

Release 2023-08-25

NB: this PR must be merged only by 'Create a merge commit'!

Checklist when preparing for release

  • Read or refresh the release flow guide
  • Ask in the cloud Slack channel that you are going to rollout the release. Any blockers?
  • Does this release contain any db migrations? Destructive ones? What is the rollback plan?

Checklist after release

@conradludgate conradludgate requested a review from a team as a code owner August 25, 2023 15:30
@conradludgate conradludgate requested review from chaporgin and removed request for a team August 25, 2023 15:30
awestover and others added 2 commits August 25, 2023 16:42
## Problem
cargo deny lint broken

Links to the CVEs:

[rustsec.org/advisories/RUSTSEC-2023-0052](https://rustsec.org/advisories/RUSTSEC-2023-0052)

[rustsec.org/advisories/RUSTSEC-2023-0053](https://rustsec.org/advisories/RUSTSEC-2023-0053)
One is fixed, the other one isn't so we allow it (for now), to unbreak
CI. Then later we'll try to get rid of webpki in favour of the rustls
fork.

## Summary of changes
```
+ignore = ["RUSTSEC-2023-0052"]
```
## Problem

We were returning Pending when a connection had a notice/notification
(introduced recently in #5020). When returning pending, the runtime
assumes you will call `cx.waker().wake()` in order to continue
processing.

We weren't doing that, so the connection task would get stuck

## Summary of changes

Don't return pending. Loop instead
@conradludgate conradludgate force-pushed the release-http-connection-fix branch from 9973a9b to ce1753d Compare August 25, 2023 15:43
@github-actions
Copy link

1624 tests run: 1548 passed, 0 failed, 76 skipped (full report)


The comment gets automatically updated with the latest test results
ce1753d at 2023-08-25T16:08:09.093Z :recycle:

@conradludgate conradludgate merged commit 9da06af into release Aug 25, 2023
@conradludgate conradludgate deleted the release-http-connection-fix branch August 25, 2023 16:21
@danieltprice
Copy link
Contributor

@vadim2404 I don't see anything in this release that requires a release note. Please let me know if I missed something.

@vadim2404
Copy link
Contributor

It was a bug fix in HTTP driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants