Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kq_imcx extension from public compute image #5201

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

lubennikovaav
Copy link
Contributor

@lubennikovaav lubennikovaav commented Sep 5, 2023

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

3229 tests run: 3113 passed, 0 failed, 116 skipped (full report)


Flaky tests (3)

Postgres 15

Postgres 14

  • test_storage_controller_smoke: debug

Code coverage* (full report)

  • functions: 32.4% (6853 of 21131 functions)
  • lines: 49.9% (53402 of 107072 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d70b40f at 2024-06-21T18:31:16.007Z :recycle:

@bayandin bayandin removed their request for review December 6, 2023 15:32
@lubennikovaav lubennikovaav force-pushed the remove_kq_imcx_extension branch from 73c9f9a to d70b40f Compare June 21, 2024 12:52
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone has this extension installed (by a mistake, or maybe they just have all extensions installed), it might break their computes, isn't it?

@lubennikovaav lubennikovaav changed the title DO NOT MERGE YET Remove kq_imcx extension from public compute image Remove kq_imcx extension from public compute image Jun 21, 2024
@lubennikovaav
Copy link
Contributor Author

If someone has this extension installed (by a mistake, or maybe they just have all extensions installed), it might break their computes, isn't it?

@bayandin

In the worst case, user will get an error like "file not found" when trying to access the extension files.
But this extension was useless without being in shared_preload_libraries anyways. And the customer, who used it already uninstalled it (see comments in the https://github.com/neondatabase/cloud/issues/13648)

If extension is in shared_preload_libraries, this error is FATAL and it will break the compute start.
But this is not the case.

I've checked pg_settings overrides and kq_imcx is not enabled for anyone
https://neonprod.grafana.net/d/fdl2zcisi4n40f/pg-settings-overrides-in-console-cplane?orgId=1

@lubennikovaav lubennikovaav merged commit 8776089 into main Jun 21, 2024
65 checks passed
@lubennikovaav lubennikovaav deleted the remove_kq_imcx_extension branch June 21, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants