Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend test_change_pageserver for failure case, rework changing pageserver #5693

Merged
merged 6 commits into from
Nov 8, 2023
Merged

extend test_change_pageserver for failure case, rework changing pageserver #5693

merged 6 commits into from
Nov 8, 2023

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented Oct 27, 2023 •
edited
Loading

Reproducer for #5692

The test change in this PR intentionally fails, to demonstrate the issue.

@jcsp jcsp requested a review from save-buffer October 27, 2023 13:02
@jcsp jcsp added c/PostgreSQL Component: PostgreSQL features and bugs a/test Area: related to testing labels Oct 27, 2023
@jcsp jcsp mentioned this pull request Oct 27, 2023
Closed
@github-actions
Copy link

github-actions bot commented Oct 27, 2023 •
edited
Loading

2370 tests run: 2255 passed, 0 failed, 115 skipped (full report)

Flaky tests (3)

Postgres 16

  • test_crafted_wal_end[wal_record_crossing_segment_followed_by_small_one]: debug
  • test_crafted_wal_end[last_wal_record_crossing_segment]: debug
  • test_pageserver_lsn_wait_error_safekeeper_stop: debug

Code coverage (full report)

  • functions: 54.7% (8898 of 16257 functions)
  • lines: 81.7% (51257 of 62762 lines)
The comment gets automatically updated with the latest test results
08446a7 at 2023-11-07T23:09:27.558Z :recycle:

@save-buffer save-buffer force-pushed the jcsp/reconfigure-hang branch 3 times, most recently from 38fcb3c to e0f9c8d Compare November 3, 2023 18:01
@save-buffer save-buffer requested a review from knizhnik November 3, 2023 19:19
@save-buffer save-buffer changed the title tests: extend test_change_pageserver for failure case extend test_change_pageserver for failure case, rework changing pageserver Nov 3, 2023
@jcsp jcsp mentioned this pull request Nov 6, 2023
Closed
knizhnik
knizhnik reviewed Nov 7, 2023
View reviewed changes
pgxn/neon/libpagestore.c Outdated Show resolved Hide resolved
@save-buffer save-buffer force-pushed the jcsp/reconfigure-hang branch from 956d9c2 to 08446a7 Compare November 7, 2023 18:44
@save-buffer save-buffer marked this pull request as ready for review November 7, 2023 23:22
@save-buffer save-buffer requested review from a team as code owners November 7, 2023 23:22
@save-buffer save-buffer requested review from chaporgin and knizhnik and removed request for a team November 7, 2023 23:22
@jcsp jcsp merged commit b989ad1 into main Nov 8, 2023
35 checks passed
@jcsp jcsp deleted the jcsp/reconfigure-hang branch November 8, 2023 11:26
jcsp added a commit that referenced this pull request Nov 9, 2023
@jcsp
Revert "extend test_change_pageserver for failure case, rework changi…
27e9cb9 
…ng pageserver (#5693)"

This reverts commit b989ad1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnica-github-connector arnica-github-connector[bot] arnica-github-connector[bot] left review comments

@knizhnik knizhnik knizhnik approved these changes

@save-buffer save-buffer Awaiting requested review from save-buffer

@chaporgin chaporgin Awaiting requested review from chaporgin chaporgin was automatically assigned from neondatabase/control-plane

Assignees
No one assigned
Labels
a/test Area: related to testing c/PostgreSQL Component: PostgreSQL features and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcsp @knizhnik @save-buffer