Cleanup compact_level0_phase1 fsyncing #5852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep the wasteful double-fsync while we have unsolved issues likely moving the fsyncs around.
koivunej
requested review from
hlinnaka and
arpad-m
and removed request for
a team
|
Does not conflict with #5234. |
arpad-m
approved these changes
Nov 10, 2023
2376 tests run: 2258 passed, 0 failed, 118 skipped (full report)Code coverage (full report)
The comment gets automatically updated with the latest test results
5014267 at 2023-11-10T19:40:03.750Z :recycle: |
hlinnaka
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Looks good as far as it goes.
I gather that create_delta_layer still needs the spawn_blocking, until we do #5479. But could we already move the par_fsync() calls out of the spawn_blocking block, and change them into par_fsync_async()? Then we could remove the synchronous par_fsync() function altogether.
problame
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing code noticed a scary
layer_paths.pop().unwrap()then realized this should be further asyncified, something I forgot to do when I switched thecompact_level0_phase1back to async in #4938.This keeps the double-fsync for new deltas as #4749 is still unsolved.