Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule image layer uploads in tiered compaction #7282

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Mar 29, 2024

Tiered compaction hasn't scheduled the upload of image layers. In the test_gc_feedback.py test this has caused warnings like with tiered compaction:

INFO request[...] Deleting layer [...] not found in latest_files list, never uploaded?

Which caused errors like:

ERROR layer_delete[...] was unlinked but was not dangling

Fixes #7244

@arpad-m arpad-m requested a review from a team as a code owner March 29, 2024 23:58
@arpad-m arpad-m requested a review from problame March 29, 2024 23:58
Copy link

2748 tests run: 2608 passed, 0 failed, 140 skipped (full report)


Code coverage* (full report)

  • functions: 28.3% (6361 of 22503 functions)
  • lines: 47.2% (44883 of 95142 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9b42ad5 at 2024-03-30T00:49:28.636Z :recycle:

Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, apologies for missing the lack of upload in the first place. I am glad I added the nagging messages :)

@arpad-m arpad-m merged commit 944313f into main Apr 3, 2024
53 checks passed
@arpad-m arpad-m deleted the arpad/image_uploads_tiered_compaction branch April 3, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new compaction: Fix failure in staircasing test
3 participants