-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing for shared locks in id_lock_map
#7618
Conversation
3216 tests run: 3074 passed, 0 failed, 142 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
b8a08c9 at 2024-06-13T10:11:12.290Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again, Jure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(meant to approve)
Just checking if there is some issue with the PR @VladLazar ? |
The issue is that I went on holiday and forgot about it. Let me sanity check it again and merge. |
Merged. Apologies for the delay and thank you, Jure! |
## Problem Storage controller shared locks do not print a warning when held for long time spans. ## Summary of changes Extension of issue #7108 in tracing to exclusive lock in `id_lock_map` was added, to add the same for shared locks. It was mentioned in the comment #7397 (comment)
Summary of changes
Extension of issue #7108 in tracing to exclusive lock in
id_lock_map
was added, to add the same for shared locks. It was mentioned in the comment #7397 (comment)Checklist before requesting a review
Checklist before merging