Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing for shared locks in id_lock_map #7618

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

jbajic
Copy link
Contributor

@jbajic jbajic commented May 6, 2024

Summary of changes

Extension of issue #7108 in tracing to exclusive lock in id_lock_map was added, to add the same for shared locks. It was mentioned in the comment #7397 (comment)

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jbajic jbajic requested a review from a team as a code owner May 6, 2024 10:48
@jbajic jbajic requested a review from VladLazar May 6, 2024 10:48
@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label May 15, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label May 15, 2024
@vipvap vipvap mentioned this pull request May 15, 2024
Copy link

github-actions bot commented May 15, 2024

3216 tests run: 3074 passed, 0 failed, 142 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_vm_bit_clear_on_heap_lock_blackbox: debug

Postgres 14

  • test_storage_controller_smoke: debug
  • test_vm_bit_clear_on_heap_lock_blackbox: debug

Code coverage* (full report)

  • functions: 31.6% (6629 of 20998 functions)
  • lines: 48.6% (51517 of 106074 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
b8a08c9 at 2024-06-13T10:11:12.290Z :recycle:

@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label May 16, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label May 16, 2024
@VladLazar VladLazar self-requested a review May 16, 2024 17:24
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, Jure!

Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(meant to approve)

@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 12, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 12, 2024
@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 12, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 12, 2024
@VladLazar VladLazar added the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 13, 2024
@github-actions github-actions bot removed the approved-for-ci-run Changes are safe to trigger CI for the PR label Jun 13, 2024
@jbajic
Copy link
Contributor Author

jbajic commented Jun 21, 2024

Just checking if there is some issue with the PR @VladLazar ?

@VladLazar
Copy link
Contributor

Just checking if there is some issue with the PR @VladLazar ?

The issue is that I went on holiday and forgot about it. Let me sanity check it again and merge.

@VladLazar VladLazar merged commit 0792bb6 into neondatabase:main Jun 21, 2024
101 of 103 checks passed
@VladLazar
Copy link
Contributor

Merged. Apologies for the delay and thank you, Jure!

conradludgate pushed a commit that referenced this pull request Jun 27, 2024
## Problem
Storage controller shared locks do not print a warning when held for long time spans.

## Summary of changes
Extension of issue #7108 in
tracing to exclusive lock in `id_lock_map` was added, to add the same
for shared locks. It was mentioned in the comment
#7397 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants