Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_ctl: Fix unused variable on non-Linux #7646

Merged
merged 1 commit into from
May 7, 2024

Conversation

sharnoff
Copy link
Member

@sharnoff sharnoff commented May 7, 2024

Problem

./run_clippy now fails on non-Linux from an unused variable introduced by #7577.

See an example check-macos-build failure here: https://github.com/neondatabase/neon/actions/runs/8992211409/job/24701531264

Summary of changes

Add #[allow(unused_variables)] to the relevant function argument.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@sharnoff sharnoff added the run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though. label May 7, 2024
@sharnoff sharnoff requested review from a team as code owners May 7, 2024 22:00
@sharnoff sharnoff requested review from NanoBjorn and save-buffer May 7, 2024 22:00
@sharnoff sharnoff enabled auto-merge (squash) May 7, 2024 22:34
@sharnoff sharnoff merged commit b827e7b into main May 7, 2024
49 of 51 checks passed
@sharnoff sharnoff deleted the sharnoff/compute-ctl-fix-unused-nonlinux branch May 7, 2024 22:35
Copy link

github-actions bot commented May 7, 2024

3024 tests run: 2891 passed, 0 failed, 133 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_detached_receives_flushes_while_being_detached[True]: debug
  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 31.2% (6256 of 20054 functions)
  • lines: 46.7% (46935 of 100592 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
766f0da at 2024-05-07T22:45:11.555Z :recycle:

conradludgate pushed a commit that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants