Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): update the config for neon_binpath in from_repo_dir #7684

Merged
merged 2 commits into from
May 9, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 9, 2024

Problem

#7637 breaks forward compat test.

On commit ea531d4.

https://neon-github-public-dev.s3.amazonaws.com/reports/main/8988324349/index.html

test_create_snapshot
2024-05-07T16:03:11.331883Z  INFO version: git-env:ea531d448eb65c4f58abb9ef7d8cd461952f7c5f failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 16:03:11.316131763 UTC build_tag: build_tag-env:5159

test_forward_compatibility
2024-05-07T16:07:02.310769Z  INFO version: git-env:ea531d448eb65c4f58abb9ef7d8cd461952f7c5f failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 16:07:02.294676183 UTC build_tag: build_tag-env:5159

The forward compatibility test is actually using the same tag as the current build.

The commit before that,

https://neon-github-public-dev.s3.amazonaws.com/reports/main/8988126011/index.html

test_create_snapshot
2024-05-07T15:47:21.900796Z  INFO version: git-env:2dbd1c1ed5cd0458933e8ffd40a9c0a5f4d610b8 failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 15:47:21.882784185 UTC build_tag: build_tag-env:5158

test_forward_compatibility
2024-05-07T15:50:48.828733Z  INFO version: git-env:c4d7d5982553d2cf66634d1fbf85d95ef44a6524 failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 15:50:48.816635176 UTC build_tag: build_tag-env:release-5434

This pull request patches the bin path so that the new neon_local will use the old binary

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/fix-forward-compat-test branch from ec3a7f6 to db607cf Compare May 9, 2024 17:37
Copy link

github-actions bot commented May 9, 2024

3024 tests run: 2892 passed, 0 failed, 132 skipped (full report)


Code coverage* (full report)

  • functions: 31.4% (6320 of 20132 functions)
  • lines: 47.3% (47622 of 100707 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f8b3478 at 2024-05-09T19:01:10.123Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented May 9, 2024

manually checked the log:

in forward compatibility test: 2024-05-09T18:38:54.243059Z INFO version: git-env:c4d7d5982553d2cf66634d1fbf85d95ef44a6524 failpoints: true, features: ["testing"] launch_timestamp: 2024-05-09 18:38:54.231427251 UTC build_tag: build_tag-env:release-5434

in test create snapshot: 2024-05-09T18:35:04.268540Z INFO version: git-env:f8b347821c1e5b22061771a880c236b42958b6e9 failpoints: true, features: ["testing"] launch_timestamp: 2024-05-09 18:35:04.255529183 UTC build_tag: build_tag-env:9021646963

auto check version will be part of #7685

@skyzh skyzh merged commit b9fd8dc into main May 9, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/fix-forward-compat-test branch May 9, 2024 19:52
skyzh added a commit that referenced this pull request May 14, 2024
A test for #7684.

This pull request checks if the pageserver version we specified is the
one actually running by comparing the git hash in forward compatibility
tests.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
a-masterov pushed a commit that referenced this pull request May 20, 2024
## Problem

#7637 breaks forward compat
test.

On commit ea531d4.


https://neon-github-public-dev.s3.amazonaws.com/reports/main/8988324349/index.html

```
test_create_snapshot
2024-05-07T16:03:11.331883Z  INFO version: git-env:ea531d448eb65c4f58abb9ef7d8cd461952f7c5f failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 16:03:11.316131763 UTC build_tag: build_tag-env:5159

test_forward_compatibility
2024-05-07T16:07:02.310769Z  INFO version: git-env:ea531d448eb65c4f58abb9ef7d8cd461952f7c5f failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 16:07:02.294676183 UTC build_tag: build_tag-env:5159
```

The forward compatibility test is actually using the same tag as the
current build.

The commit before that,


https://neon-github-public-dev.s3.amazonaws.com/reports/main/8988126011/index.html

```
test_create_snapshot
2024-05-07T15:47:21.900796Z  INFO version: git-env:2dbd1c1ed5cd0458933e8ffd40a9c0a5f4d610b8 failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 15:47:21.882784185 UTC build_tag: build_tag-env:5158

test_forward_compatibility
2024-05-07T15:50:48.828733Z  INFO version: git-env:c4d7d5982553d2cf66634d1fbf85d95ef44a6524 failpoints: true, features: ["testing"] launch_timestamp: 2024-05-07 15:50:48.816635176 UTC build_tag: build_tag-env:release-5434
```

This pull request patches the bin path so that the new neon_local will
use the old binary.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
a-masterov pushed a commit that referenced this pull request May 20, 2024
A test for #7684.

This pull request checks if the pageserver version we specified is the
one actually running by comparing the git hash in forward compatibility
tests.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants