-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pagebench): add aux file bench #7746
Conversation
3078 tests run: 2951 passed, 0 failed, 127 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f106bdd at 2024-05-17T20:11:49.253Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new pagebench isn't measuring anything, and the workload it applies isn't parametrizable via CLI. It seems quite incomplete to me.
I'm ok with merging it if you intend to extend it later, would be nice to link the follow-up issue for that.
Approval is subject to changing the POST
API to testing_api_handler, I don't think it's safe to use if there's a concurrent other DatadirModification
s.
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
14f5803
to
df34c0a
Compare
Signed-off-by: Alex Chi Z <chi@neon.tech>
df34c0a
to
1dc17e0
Compare
Signed-off-by: Alex Chi Z <chi@neon.tech>
part of #7462 ## Summary of changes This pull request adds two APIs to the pageserver management API: list_aux_files and ingest_aux_files. The aux file pagebench is intended to be used on an empty timeline because the data do not go through the safekeeper. LSNs are advanced by 8 for each ingestion, to avoid invariant checks inside the pageserver. For now, I only care about space amplification / read amplification, so the bench is designed in a very simple way: ingest 10000 files, and I will manually dump the layer map to analyze. --------- Signed-off-by: Alex Chi Z <chi@neon.tech>
Problem
part of #7462
Summary of changes
This pull request adds two APIs to the pageserver management API: list_aux_files and ingest_aux_files. The aux file pagebench is intended to be used on an empty timeline because the data do not go through the safekeeper. LSNs are advanced by 8 for each ingestion, to avoid invariant checks inside the pageserver.
For now, I only care about space amplification / read amplification, so the bench is designed in a very simple way: ingest 10000 files, and I will manually dump the layer map to analyze.
Checklist before requesting a review
Checklist before merging