Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pageserver): remove aux v1 keyspace if user fully switches to v2 #7824

Closed
wants to merge 2 commits into from

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 21, 2024

Problem

A follow-up on #7462

If a user is switched to v2, their v1 data is no longer accessible, so we can remove them by not including the aux_file_key in the keyspace.

No need to merge it now in case we want to force switch some user back from v2, but I'd like to get an approval first so that we can merge it any time we want.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner May 21, 2024 15:23
@skyzh skyzh requested review from VladLazar and arpad-m and removed request for VladLazar May 21, 2024 15:23
Copy link

github-actions bot commented May 21, 2024

3096 tests run: 2969 passed, 0 failed, 127 skipped (full report)


Flaky tests (3)

Postgres 16

  • test_secondary_background_downloads: release
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 14

  • test_timeline_deletion_with_files_stuck_in_upload_queue: debug

Code coverage* (full report)

  • functions: 31.4% (6413 of 20425 functions)
  • lines: 48.0% (49321 of 102674 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
496e96c at 2024-05-21T18:31:07.443Z :recycle:

Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

pageserver/src/tenant.rs Outdated Show resolved Hide resolved
Co-authored-by: Arpad Müller <arpad-m@users.noreply.github.com>
@skyzh skyzh closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants