Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: remove AncestorStopping error variants #7916

Merged
merged 2 commits into from
May 31, 2024

Conversation

jcsp
Copy link
Collaborator

@jcsp jcsp commented May 30, 2024

Problem

In all cases, AncestorStopping is equivalent to Cancelled.

This became more obvious in #7912 (comment) when updating these error types.

Summary of changes

  • Remove AncestorStopping, always use Cancelled instead

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented May 30, 2024

3156 tests run: 3017 passed, 0 failed, 139 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_location_conf_churn[2]: release

Code coverage* (full report)

  • functions: 31.4% (6493 of 20689 functions)
  • lines: 48.4% (50220 of 103831 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f4305e7 at 2024-05-31T14:52:28.674Z :recycle:

@jcsp jcsp force-pushed the jcsp/no-ancestor-stopping branch from 221bed5 to f4305e7 Compare May 31, 2024 14:02
@jcsp jcsp marked this pull request as ready for review May 31, 2024 15:50
@jcsp jcsp requested a review from a team as a code owner May 31, 2024 15:50
@jcsp jcsp requested review from VladLazar and skyzh and removed request for VladLazar May 31, 2024 15:50
@jcsp jcsp merged commit 9fda85b into main May 31, 2024
64 of 65 checks passed
@jcsp jcsp deleted the jcsp/no-ancestor-stopping branch May 31, 2024 16:02
a-masterov pushed a commit that referenced this pull request Jun 3, 2024
## Problem

In all cases, AncestorStopping is equivalent to Cancelled.

This became more obvious in
#7912 (comment)
when updating these error types.

## Summary of changes

- Remove AncestorStopping, always use Cancelled instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants