Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): more flexible layer size test #7945

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 3, 2024

Problem

M-series macOS has different alignments/size for some fields (which I did not investigate in detail) and therefore this test cannot pass on macOS. Fixed by using <= for the comparison so that we do not test for an exact match.

observed by @yliang412

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from koivunej June 3, 2024 16:39
@skyzh skyzh requested a review from a team as a code owner June 3, 2024 16:39
Copy link

github-actions bot commented Jun 3, 2024

3204 tests run: 3065 passed, 0 failed, 139 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_subscriber_restart: release
  • test_compaction_induced_by_detaches_in_history: release
  • test_vm_bit_clear_on_heap_lock: debug

Postgres 15

  • test_statvfs_pressure_usage: debug
  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 31.6% (6607 of 20917 functions)
  • lines: 48.5% (51065 of 105214 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3b228fc at 2024-06-06T15:22:55.821Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/macos-layer-size branch from c211706 to 3b228fc Compare June 5, 2024 17:52
@skyzh skyzh requested a review from koivunej June 5, 2024 17:52
@skyzh
Copy link
Member Author

skyzh commented Jun 5, 2024

Checked the test is running in CI while ignored on macOS.

        PASS [   0.007s] pageserver tenant::storage_layer::layer::tests::layer_size

Ready for review.

@skyzh skyzh enabled auto-merge (squash) June 6, 2024 14:26
@skyzh skyzh merged commit 0145099 into main Jun 6, 2024
64 checks passed
@skyzh skyzh deleted the skyzh/macos-layer-size branch June 6, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants