-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add On-demand WAL Download to logicalfuncs #7960
Conversation
3daf643
to
602475b
Compare
3204 tests run: 3062 passed, 0 failed, 142 skipped (full report)Flaky tests (2)Postgres 16Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
93c79c3 at 2024-06-11T21:13:39.625Z :recycle: |
I'm a reviewer on this PR, but I have no idea what it's about. Please always write a description that fills out the PR template -- that's helpful even if a linked issue is provided, but in this case the link goes to a PR that has an empty description too. |
Sorry, I did have an issue that links to a slack thread but I didn't paste correctly. I've added a description |
@save-buffer that PR would benefit from a test that can reproduce the issue without a fix and would pass with fix :-) |
Error message looks like that:
(posting here so that search on the error message could find this issue; originally i went in https://github.com/neondatabase/cloud/issues/12992). |
Also double-checked that user faces |
Added a test |
Without callbacks:
With callbacks: test passes |
5e58980
to
7af9ae3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's also run pgindent on C part.
3617612
to
93c79c3
Compare
We implemented on-demand WAL download for walsender, but other things that may want to read the WAL from safekeepers don't do that yet. This PR makes it do that by adding the same set of hooks to logicalfuncs. Addresses #7959 Also relies on: neondatabase/postgres#438 neondatabase/postgres#437 neondatabase/postgres#436
We implemented on-demand WAL download for walsender, but other things that may want to read the WAL from safekeepers don't do that yet. This PR makes it do that by adding the same set of hooks to logicalfuncs.
Addresses #7959
Also relies on:
neondatabase/postgres#438
neondatabase/postgres#437
neondatabase/postgres#436