Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade No response from reading prefetch entry WARNING to LOG #7988

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

lubennikovaav
Copy link
Contributor

Problem

This WARNING can be caused by normal reconnection, i.e. because of pageserver restart.
We don't need to keep it user-visible warning, because it is not actionable.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@lubennikovaav lubennikovaav requested review from a team as code owners June 6, 2024 19:14
@lubennikovaav lubennikovaav enabled auto-merge (rebase) June 6, 2024 19:16
@lubennikovaav lubennikovaav merged commit 66c6b27 into main Jun 6, 2024
56 of 57 checks passed
@lubennikovaav lubennikovaav deleted the downgrade_prefetch_warning_to_log branch June 6, 2024 19:56
Copy link

github-actions bot commented Jun 6, 2024

3192 tests run: 3054 passed, 0 failed, 138 skipped (full report)


Flaky tests (2)

Postgres 15

  • test_storage_controller_smoke: release

Postgres 14

  • test_storage_controller_smoke: debug

Code coverage* (full report)

  • functions: 31.5% (6605 of 20937 functions)
  • lines: 48.5% (51074 of 105314 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d45a9e6 at 2024-06-06T20:04:15.093Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants