Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: highlight neon env comes with an initial timeline #7995

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 7, 2024

Problem

Quite a few existing test cases create their own timelines instead of using the default one. This pull request highlights that and hopefully people can write simpler tests in the future.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from yliang412 June 7, 2024 18:29
Copy link
Contributor

@yliang412 yliang412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Added some comments related to what I learned from writing my first test.

test_runner/README.md Outdated Show resolved Hide resolved
Co-authored-by: Yuchen Liang <70461588+yliang412@users.noreply.github.com>
Copy link

github-actions bot commented Jun 7, 2024

3192 tests run: 3053 passed, 0 failed, 139 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_storage_controller_smoke: release

Code coverage* (full report)

  • functions: 31.5% (6599 of 20937 functions)
  • lines: 48.5% (51047 of 105314 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
c327dc9 at 2024-06-07T20:05:28.423Z :recycle:

@skyzh skyzh merged commit a8ca7a1 into main Jun 10, 2024
64 checks passed
@skyzh skyzh deleted the skyzh/update-test-runner branch June 10, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants