-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pageserver): add test keyspace into collect_keyspace #8016
Conversation
Signed-off-by: Alex Chi Z <chi@neon.tech>
3234 tests run: 3092 passed, 0 failed, 142 skipped (full report)Flaky tests (7)Postgres 16Postgres 15
Postgres 14Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
62d732a at 2024-06-12T17:51:40.450Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear enough from the comments why you called it extra_test_dense_keyspace
as opposed to extra_test_keyspace
What's the context for this change? AuxFilesV2 or the new compaction algorithm?
collect_keyspace returns two values: dense keyspace and sparse keyspace. For sparse keyspace, the test cases can simply use AUX keys for testing; for dense keyspace, users should add their keyspace into the extra keyspace. Probably I should add both |
Signed-off-by: Alex Chi Z <chi@neon.tech>
f8f2f1f
to
62d732a
Compare
Fixing some existing test cases that might be flaky b/c the keys could be garbage-collected, and also make the compaction algorithm tests able to use the data keyspace to do WAL replays. |
Problem
Some test cases add random keys into the timeline, but it is not part of the
collect_keyspace
, this will cause compaction remove the keys.Summary of changes
The pull request adds a field to supply extra keyspaces during unit tests.
Checklist before requesting a review
Checklist before merging