Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon_cli: do not drain to undesirable nodes #8027

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

The previous code would attempt to drain to unavailable or unschedulable nodes.

Summary of Changes

Remove such nodes from the list of nodes to fill.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Problem
The previous code would attempt to drain to unavailable or unschedulable
nodes.

Summary of Changes
Remove such nodes from the list of nodes to fill.
@VladLazar VladLazar requested a review from arpad-m June 12, 2024 10:17
Copy link

3210 tests run: 3068 passed, 0 failed, 142 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_vm_bit_clear_on_heap_lock_blackbox: release

Code coverage* (full report)

  • functions: 31.6% (6627 of 20989 functions)
  • lines: 48.6% (51495 of 106042 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6917ed0 at 2024-06-12T11:05:26.635Z :recycle:

Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, when I read that filter invocation I was wondering whether some duplication could be saved by unifying with a probably similar check below but by the time I came to the code below I forgot about the fact that this filtering is needed at all 😆

@VladLazar VladLazar merged commit 3099e1a into main Jun 12, 2024
64 checks passed
@VladLazar VladLazar deleted the vlad/storconcli-drain-fix branch June 12, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants