Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(check-build-tools-image): change build-tools image persistent tag #8059

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jun 14, 2024

Problem

We don't rebuild build-tools image for changes in a workflow that builds this image itself (.github/workflows/build-build-tools-image.yml) or in a workflow that determines which tag to use (.github/workflows/check-build-tools-image.yml)

Summary of changes

  • Use a hash of Dockerfile.build-tools and workflow files as a persistent tag instead of commit sha.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin force-pushed the bayandin/build-tools-image-tag branch from 98ed208 to 8df226b Compare June 14, 2024 11:51
Copy link

3216 tests run: 3074 passed, 0 failed, 142 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_timeline_size_quota_on_startup: release

Code coverage* (full report)

  • functions: 31.5% (6632 of 21063 functions)
  • lines: 48.6% (51614 of 106296 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8df226b at 2024-06-14T12:45:40.007Z :recycle:

@bayandin bayandin marked this pull request as ready for review June 14, 2024 15:45
@bayandin bayandin requested a review from a-masterov June 17, 2024 11:09
Copy link
Contributor

@a-masterov a-masterov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@bayandin bayandin merged commit b6e1c09 into main Jun 17, 2024
69 checks passed
@bayandin bayandin deleted the bayandin/build-tools-image-tag branch June 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants