Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottom-most-compaction: use in test_gc_feedback + fix bugs #8103

Merged
merged 8 commits into from
Jun 25, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 18, 2024

Problem

Adds manual compaction trigger; add gc compaction to test_gc_feedback

Part of #8002

test_gc_feedback[debug-pg15].logical_size: 50 Mb
test_gc_feedback[debug-pg15].physical_size: 2269 Mb
test_gc_feedback[debug-pg15].physical/logical ratio: 44.5302 
test_gc_feedback[debug-pg15].max_total_num_of_deltas: 7 
test_gc_feedback[debug-pg15].max_num_of_deltas_above_image: 2 
test_gc_feedback[debug-pg15].logical_size_after_bottom_most_compaction: 50 Mb
test_gc_feedback[debug-pg15].physical_size_after_bottom_most_compaction: 287 Mb
test_gc_feedback[debug-pg15].physical/logical ratio after bottom_most_compaction: 5.6312 
test_gc_feedback[debug-pg15].max_total_num_of_deltas_after_bottom_most_compaction: 4 
test_gc_feedback[debug-pg15].max_num_of_deltas_above_image_after_bottom_most_compaction: 1

Summary of changes

  • Add the manual compaction trigger
  • Use in test_gc_feedback
  • Add a guard to avoid running it with retain_lsns
  • Fix: Do schedule_compaction_update after compaction
  • Fix: Supply deltas in the correct order to reconstruct value

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jun 18, 2024

2998 tests run: 2872 passed, 0 failed, 126 skipped (full report)


Code coverage* (full report)

  • functions: 32.8% (6888 of 21016 functions)
  • lines: 50.3% (53885 of 107171 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1433f80 at 2024-06-25T22:26:45.819Z :recycle:

@skyzh skyzh changed the title [DNM] feat(pageserver): add manual trigger for bottom-most compaction feat(pageserver): add manual trigger for bottom-most compaction Jun 24, 2024
Base automatically changed from skyzh/legacy-enhanced-gc-delta to main June 24, 2024 15:50
skyzh added 3 commits June 24, 2024 11:52
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/manual-trigger-compaction-gc branch from c1a6261 to d611468 Compare June 24, 2024 15:59
@skyzh skyzh marked this pull request as ready for review June 24, 2024 15:59
@skyzh skyzh requested a review from a team as a code owner June 24, 2024 15:59
@skyzh skyzh requested review from VladLazar and problame June 24, 2024 15:59
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/manual-trigger-compaction-gc branch from d611468 to 504c9a6 Compare June 24, 2024 16:00
Signed-off-by: Alex Chi Z <chi@neon.tech>
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better title for this PR would be:

bottom-most compaction: use in test_gc_feedback + fix bugs this revealed

And please enumerate / mention the list of bugs fixed in the PR description

pageserver/src/tenant/timeline/compaction.rs Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Show resolved Hide resolved
test_runner/performance/test_gc_feedback.py Show resolved Hide resolved
@skyzh skyzh changed the title feat(pageserver): add manual trigger for bottom-most compaction bottom-most-compaction: use in test_gc_feedback + fix bugs Jun 25, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from problame June 25, 2024 19:33
@skyzh skyzh added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Jun 25, 2024
Copy link
Contributor

@problame problame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a work issue for the pitr_interval: ... stuff and track it in your epic!

@skyzh skyzh disabled auto-merge June 25, 2024 20:58
@skyzh skyzh enabled auto-merge (squash) June 25, 2024 22:43
@skyzh skyzh merged commit 9b98823 into main Jun 25, 2024
68 checks passed
@skyzh skyzh deleted the skyzh/manual-trigger-compaction-gc branch June 25, 2024 23:00
skyzh added a commit that referenced this pull request Jun 26, 2024
A follow-up on #8103.
Previously, main branch fails with:

```
assertion `left == right` failed
  left: b"value 3@0x10@0x30@0x28@0x40"
 right: b"value 3@0x10@0x28@0x30@0x40"
```

This gets fixed after #8103 gets merged.


Signed-off-by: Alex Chi Z <chi@neon.tech>
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
Adds manual compaction trigger; add gc compaction to test_gc_feedback

Part of #8002

```
test_gc_feedback[debug-pg15].logical_size: 50 Mb
test_gc_feedback[debug-pg15].physical_size: 2269 Mb
test_gc_feedback[debug-pg15].physical/logical ratio: 44.5302 
test_gc_feedback[debug-pg15].max_total_num_of_deltas: 7 
test_gc_feedback[debug-pg15].max_num_of_deltas_above_image: 2 
test_gc_feedback[debug-pg15].logical_size_after_bottom_most_compaction: 50 Mb
test_gc_feedback[debug-pg15].physical_size_after_bottom_most_compaction: 287 Mb
test_gc_feedback[debug-pg15].physical/logical ratio after bottom_most_compaction: 5.6312 
test_gc_feedback[debug-pg15].max_total_num_of_deltas_after_bottom_most_compaction: 4 
test_gc_feedback[debug-pg15].max_num_of_deltas_above_image_after_bottom_most_compaction: 1
```

## Summary of changes

* Add the manual compaction trigger
* Use in test_gc_feedback
* Add a guard to avoid running it with retain_lsns
* Fix: Do `schedule_compaction_update` after compaction
* Fix: Supply deltas in the correct order to reconstruct value

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
A follow-up on #8103.
Previously, main branch fails with:

```
assertion `left == right` failed
  left: b"value 3@0x10@0x30@0x28@0x40"
 right: b"value 3@0x10@0x28@0x30@0x40"
```

This gets fixed after #8103 gets merged.


Signed-off-by: Alex Chi Z <chi@neon.tech>
github-merge-queue bot pushed a commit that referenced this pull request Dec 18, 2024
## Problem

In #8103 we changed the test
case to have more test coverage of gc_compaction. Now that we have
`test_gc_compaction_smoke`, we can revert this test case to serve its
original purpose and revert the parameter changes.

part of #9114

## Summary of changes

* Revert pitr_interval from 60s to 10s.
* Assert the physical/logical size ratio in the benchmark.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Co-authored-by: Arpad Müller <arpad-m@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants