-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tense of errors #8234
Merged
Merged
tense of errors #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
added
c/storage/pageserver
Component: storage: pageserver
a/tech_debt
Area: related to tech debt
labels
Jul 2, 2024
problame
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you had added one thiserror
somewhere that was using present progressive
3000 tests run: 2885 passed, 0 failed, 115 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
cf285d6 at 2024-07-02T15:57:58.828Z :recycle: |
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
I forgot a commit when merging #8177
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
I forgot a commit when merging #8177
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
I forgot a commit when merging #8177
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
I forgot a commit when merging #8177
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
I forgot a commit when merging #8177
VladLazar
pushed a commit
that referenced
this pull request
Jul 8, 2024
I forgot a commit when merging #8177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot a commit when merging #8177
Checklist before requesting a review
Checklist before merging