Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage-scrubber): allow disable file logging #8297

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jul 5, 2024

Problem

part of https://github.com/neondatabase/cloud/issues/14024, k8s does not always have a volume available for logging, and I'm running into weird permission errors... While I could spend time figuring out how to create temp directories for logging, I think it would be better to just disable file logging as k8s containers are ephemeral and we cannot retrieve anything on the fs after the container gets removed.

Summary of changes

PAGESERVER_DISABLE_FILE_LOGGING=1 -> file logging disabled

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from jcsp July 5, 2024 19:57
storage_scrubber/src/lib.rs Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 5, 2024

3067 tests run: 2952 passed, 0 failed, 115 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_pg_regress[4]: debug
  • test_tenant_creation_fails: debug

Code coverage* (full report)

  • functions: 32.6% (6939 of 21281 functions)
  • lines: 50.0% (54556 of 109075 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
0a2969a at 2024-07-09T15:30:48.185Z :recycle:

@skyzh skyzh enabled auto-merge (squash) July 8, 2024 19:34
skyzh added 3 commits July 8, 2024 17:09
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/scrubber-logging branch from 068ef4d to 0a2969a Compare July 8, 2024 21:10
@skyzh skyzh merged commit 73fa3c0 into main Jul 9, 2024
69 checks passed
@skyzh skyzh deleted the skyzh/scrubber-logging branch July 9, 2024 16:11
skyzh added a commit that referenced this pull request Jul 15, 2024
part of neondatabase/cloud#14024, k8s does not
always have a volume available for logging, and I'm running into weird
permission errors... While I could spend time figuring out how to create
temp directories for logging, I think it would be better to just disable
file logging as k8s containers are ephemeral and we cannot retrieve
anything on the fs after the container gets removed.
  
## Summary of changes

`PAGESERVER_DISABLE_FILE_LOGGING=1` -> file logging disabled

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants