-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rolling storage controller restarts RFC #8310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3806 tests run: 3700 passed, 0 failed, 106 skipped (full report)Flaky tests (5)Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
bfb0c59 at 2024-08-28T14:04:56.984Z :recycle: |
jcsp
reviewed
Jul 8, 2024
yliang412
reviewed
Jul 9, 2024
yliang412
reviewed
Jul 9, 2024
jcsp
approved these changes
Jul 10, 2024
VladLazar
commented
Jul 12, 2024
Thinking of extra safety measures: we might in future like to carry an HTTP header on controller requests to pageservers, which would change for new leaders, so that pageservers could refuse requests from stale leaders. Might be worth embedding some counter in the |
5 tasks
VladLazar
added a commit
that referenced
this pull request
Jul 26, 2024
## Problem We are missing the step-down primitive required to implement rolling restarts of the storage controller. ## Summary of changes Add `/control/v1/step_down` endpoint which puts the storage controller into a state where it rejects all API requests apart from `/control/v1/step_down`, `/status` and `/metrics`. When receiving the request, storage controller cancels all pending reconciles and waits for them to exit gracefully. The response contains a snapshot of the in-memory observed state. Related: * neondatabase/cloud#14701 * #7797 * #8310
5 tasks
VladLazar
added a commit
to neondatabase/helm-charts
that referenced
this pull request
Aug 22, 2024
Add a startAsCandidate setting for the storcon helm chart (default false). When set to true, the service restarts gracefully (see neondatabase/neon#8310). This doesn't change anything as is. Changes to neondatabase/infra will stage the roll-out of this.
VladLazar
force-pushed
the
vlad/storcon-improved-restarts-rfc
branch
from
August 28, 2024 11:13
91b4533
to
bfb0c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Storage controller upgrades (restarts, more generally) can cause multi-second availability gaps.
While the storage controller does not sit on the main data path, it's generally not acceptable
to block management requests for extended periods of time (e.g. #8034).
Summary of changes
This RFC describes the issues around the current storage controller restart procedure
and describes an implementation which reduces downtime to a few milliseconds on the happy path.
Related #7797
Checklist before requesting a review
Checklist before merging