Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Performance bench on more platforms #8312

Merged
merged 11 commits into from
Jul 11, 2024

Conversation

Bodobolero
Copy link
Contributor

@Bodobolero Bodobolero commented Jul 8, 2024

Problem

https://github.com/neondatabase/cloud/issues/14721

Summary of changes

add one more platform to benchmarking job

https://github.com/neondatabase/neon/blob/57535c039c938f7c179693d9db8b052912019823/.github/workflows/benchmarking.yml#L57C3-L126

Run with pg 16, provisioner k8-neonvm by default on the new platform.

Adjust some test cases to

  • not depend on database client <-> database server latency by pushing loops into server side pl/pgSQL functions
  • increase statement and test timeouts

First successful run of these job steps
https://github.com/neondatabase/neon/actions/runs/9869817756/job/27254280428

@Bodobolero Bodobolero marked this pull request as draft July 8, 2024 14:40
Copy link

github-actions bot commented Jul 8, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Flaky tests (3)

Postgres 16

Postgres 14

  • test_tenant_creation_fails: debug

Code coverage* (full report)

  • functions: 32.5% (6932 of 21300 functions)
  • lines: 49.9% (54532 of 109200 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
86e8d8d at 2024-07-10T12:45:53.174Z :recycle:

@Bodobolero Bodobolero force-pushed the bodobolero/bench_on_other_cloud branch from af51c69 to b8e1e6c Compare July 9, 2024 14:48
@Bodobolero Bodobolero marked this pull request as ready for review July 10, 2024 11:53
@Bodobolero Bodobolero enabled auto-merge (squash) July 10, 2024 12:59
@Bodobolero Bodobolero merged commit c11b9cb into main Jul 11, 2024
69 checks passed
@Bodobolero Bodobolero deleted the bodobolero/bench_on_other_cloud branch July 11, 2024 09:07
skyzh pushed a commit that referenced this pull request Jul 15, 2024
## Problem

neondatabase/cloud#14721

## Summary of changes

add one more platform to benchmarking job 


https://github.com/neondatabase/neon/blob/57535c039c938f7c179693d9db8b052912019823/.github/workflows/benchmarking.yml#L57C3-L126

Run with pg 16, provisioner k8-neonvm by default on the new platform.

Adjust some test cases to

- not depend on database client <-> database server latency by pushing
loops into server side pl/pgSQL functions
- increase statement and test timeouts

First successful run of these job steps 

https://github.com/neondatabase/neon/actions/runs/9869817756/job/27254280428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants