Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): write to both v1+v2 for aux tenant import #8316

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jul 8, 2024

Problem

close #8202 ref #6560

For tenant imports, we now write the aux files into both v1+v2 storage, so that the test case can pick either one for testing. Given the API is only used for testing, this looks like a safe change.

I did not test it b/c there are no existing test cases. Probably @knizhnik can help with the testing?

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from knizhnik July 8, 2024 17:09
@skyzh skyzh marked this pull request as ready for review July 8, 2024 17:09
@skyzh skyzh requested a review from a team as a code owner July 8, 2024 17:09
@skyzh skyzh requested a review from arpad-m July 8, 2024 17:09
Copy link

github-actions bot commented Jul 8, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.6% (6936 of 21280 functions)
  • lines: 50.0% (54544 of 109066 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
bee2cba at 2024-07-08T18:54:24.117Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh force-pushed the skyzh/fix-aux-import branch from 0b7c040 to bee2cba Compare July 8, 2024 18:07
@skyzh skyzh enabled auto-merge (squash) July 8, 2024 18:38
@skyzh skyzh merged commit df3dc6e into main Jul 8, 2024
65 checks passed
@skyzh skyzh deleted the skyzh/fix-aux-import branch July 8, 2024 19:06
skyzh added a commit that referenced this pull request Jul 15, 2024
close #8202 ref
#6560

For tenant imports, we now write the aux files into both v1+v2 storage,
so that the test case can pick either one for testing. Given the API is
only used for testing, this looks like a safe change.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: handle aux file keys in imports
2 participants