Use DefaultCredentialsChain AWS authentication in remote_storage #8440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3144 tests run: 3023 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
be946eb at 2024-07-19T19:03:52.889Z :recycle: |
conradludgate
approved these changes
Jul 19, 2024
skyzh
approved these changes
Jul 19, 2024
jcsp
approved these changes
Jul 19, 2024
arssher
approved these changes
Jul 19, 2024
problame
pushed a commit
that referenced
this pull request
Jul 22, 2024
PR #8299 has switched the storage scrubber to use `DefaultCredentialsChain`. Now we do this for `remote_storage`, as it allows us to use `remote_storage` from inside kubernetes. Most of the diff is due to `GenericRemoteStorage::from_config` becoming `async fn`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8299 has switched the storage scrubber to use
DefaultCredentialsChain. Now we do this forremote_storage, as it allows us to useremote_storagefrom inside kubernetes. Most of the diff is due toGenericRemoteStorage::from_configbecomingasync fn.