-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement archival_config timeline endpoint in the storage controller #8680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3808 tests run: 3702 passed, 0 failed, 106 skipped (full report)Flaky tests (3)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d315d66 at 2024-09-02T10:49:47.732Z :recycle: |
Can you update existing tests to invoke the API via the storage controller instead of directly on the pageserver, so that we have some coverage of this? |
arpad-m
force-pushed
the
arpad/storage_controller_timeline_archival
branch
2 times, most recently
from
August 24, 2024 12:02
71f4740
to
b80eb8b
Compare
There haven't been any tests so I wrote #8824 to address that. |
koivunej
reviewed
Aug 26, 2024
koivunej
reviewed
Aug 26, 2024
koivunej
reviewed
Aug 26, 2024
koivunej
reviewed
Aug 28, 2024
arpad-m
force-pushed
the
arpad/storage_controller_timeline_archival
branch
from
August 28, 2024 13:35
b80eb8b
to
51f84f9
Compare
arpad-m
force-pushed
the
arpad/storage_controller_timeline_archival
branch
from
August 29, 2024 21:14
89c00b0
to
b68644e
Compare
arpad-m
force-pushed
the
arpad/storage_controller_timeline_archival
branch
from
August 29, 2024 21:25
b68644e
to
89160c6
Compare
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
reviewed
Aug 30, 2024
koivunej
requested changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See threads.
koivunej
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the timeline specific
archival_config
endpoint also in the storage controller.It's mostly a copy-paste of the detach handler: the task is the same: do the same operation on all shards.
Part of #8088.