Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safekeeper: add term_bump endpoint #8753

Merged
merged 1 commit into from
Sep 6, 2024
Merged

safekeeper: add term_bump endpoint #8753

merged 1 commit into from
Sep 6, 2024

Conversation

arssher
Copy link
Contributor

@arssher arssher commented Aug 19, 2024

No description provided.

@arssher arssher requested a review from petuhovskiy August 19, 2024 11:46
@arssher arssher requested review from a team as code owners August 19, 2024 11:46
@arssher arssher requested review from skyzh and knizhnik August 19, 2024 11:46
Copy link

github-actions bot commented Aug 19, 2024

3843 tests run: 3729 passed, 0 failed, 114 skipped (full report)


Flaky tests (4)

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.9% (7346 of 23064 functions)
  • lines: 50.0% (59486 of 118942 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f492655 at 2024-09-06T15:07:23.246Z :recycle:

Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only for testing purpose, you can wrap it with testing_api_handler in routes.rs. Rest LGTM :)

@arssher
Copy link
Contributor Author

arssher commented Aug 20, 2024

No, it is actually going to be used.

When walproposer observes now higher term it restarts instead of
crashing whole compute with PANIC; this avoids compute crash after
term_bump call. After successfull election we're still checking
last_log_term of the highest given vote to ensure basebackup is good,
and PANIC otherwise.

It will be used for migration per
035-safekeeper-dynamic-membership-change.md
and
neondatabase/docs#21

ref #8700
@arssher arssher merged commit 11cf16e into main Sep 6, 2024
67 checks passed
@arssher arssher deleted the sk-bump-term branch September 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants