-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safekeeper scrubber test #8785
Conversation
5264756
to
ea2abf6
Compare
3827 tests run: 3721 passed, 0 failed, 106 skipped (full report)Flaky tests (4)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
666295e at 2024-08-30T23:08:09.611Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @yliang412 might want to add this to the cron job if necessary?
I think we can do it if the checks are stable + do not emit false positive. As part of #8128, I only checked into pageserver's metadata scan code. |
The test is very rudimentary, it only checks that before and after tenant deletion, we can run
scan_metadata
for the safekeeper node kind. Also, we don't actually expect any uploaded data, for that we don't have enough WAL (needs to create at least one S3-uploaded file, the scrubber doesn't recognize partial files yet).The
scan_metadata
scrubber subcommand is extended to support either specifying a database connection string, which was previously the only way, and required a database to be present, or specifying the timeline information manually via json. This is ideal for testing scenarios because in those, the number of timelines is usually limited.