Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage-scrubber): make retry error into warnings #8851

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Aug 27, 2024

Problem

We get many HTTP connect timeout errors from scrubber logs, and it turned out that the scrubber is retrying, and this is not an actual error. In the future, we should revisit all places where we log errors in the storage scrubber, and only error when necessary (i.e., errors that might need manual fixing)

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested a review from arpad-m August 27, 2024 19:37
Copy link

3780 tests run: 3674 passed, 0 failed, 106 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.3% (7309 of 22610 functions)
  • lines: 50.4% (59104 of 117260 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
2767122 at 2024-08-27T20:22:16.529Z :recycle:

Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH if this were in the pageserver, I'd suggest using the info log level even, as it's nothing unexpected.

@skyzh
Copy link
Member Author

skyzh commented Aug 28, 2024

Well, I still prefer having a warning for whatever things go wrong even if it's self recoverable... 😛

@skyzh skyzh merged commit 63a0d0d into main Aug 28, 2024
69 checks passed
@skyzh skyzh deleted the skyzh/scrubber-warning branch August 28, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants