Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unarchive a timeline if its ancestor is archived #8853

Merged
merged 8 commits into from
Aug 29, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Aug 28, 2024

If a timeline unarchival request comes in, give an error if the parent timeline is archived. This prevents us from the situation of having an archived timeline with children that are not archived.

Follow up of #8824

Part of #8088

@arpad-m arpad-m requested a review from a team as a code owner August 28, 2024 12:13
@arpad-m arpad-m requested review from skyzh and koivunej August 28, 2024 12:13
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
pageserver/src/tenant.rs Outdated Show resolved Hide resolved
Copy link
Member

@koivunej koivunej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's never log an error and then return an error.

arpad-m and others added 2 commits August 28, 2024 14:44
Co-authored-by: Joonas Koivunen <joonas@neon.tech>
@arpad-m arpad-m requested a review from koivunej August 28, 2024 13:09
Copy link

github-actions bot commented Aug 28, 2024

3801 tests run: 3695 passed, 0 failed, 106 skipped (full report)


Flaky tests (2)

Postgres 16

Code coverage* (full report)

  • functions: 32.5% (7411 of 22796 functions)
  • lines: 50.7% (60194 of 118723 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d2b7619 at 2024-08-29T13:08:08.286Z :recycle:

@arpad-m arpad-m enabled auto-merge (squash) August 29, 2024 11:16
@arpad-m arpad-m merged commit 96b5c4d into main Aug 29, 2024
63 checks passed
@arpad-m arpad-m deleted the arpad/timeline_archival_unarchive_child branch August 29, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants