-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storcon: make pageserver AZ id mandatory #8856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLazar
changed the title
Vlad/storcon make ps az mandatory
storcon: make pageserver AZ id mandatory
Aug 28, 2024
5 tasks
3822 tests run: 3712 passed, 0 failed, 110 skipped (full report)Flaky tests (4)Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
e10a76f at 2024-09-04T13:25:39.267Z :recycle: |
VladLazar
force-pushed
the
vlad/storcon-make-ps-az-mandatory
branch
2 times, most recently
from
September 3, 2024 11:15
b2cffe1
to
e4a59e7
Compare
VladLazar
force-pushed
the
vlad/storcon-make-ps-az-mandatory
branch
from
September 3, 2024 12:28
e4a59e7
to
959c701
Compare
VladLazar
force-pushed
the
vlad/neon-local-ps-az
branch
from
September 3, 2024 13:05
cc593b4
to
3b986b8
Compare
VladLazar
force-pushed
the
vlad/storcon-make-ps-az-mandatory
branch
from
September 3, 2024 13:06
959c701
to
4cd6c65
Compare
VladLazar
force-pushed
the
vlad/storcon-make-ps-az-mandatory
branch
2 times, most recently
from
September 3, 2024 15:45
3934ebd
to
21d5ccb
Compare
VladLazar
added
the
backward compatibility breakage
Broken backward compatibility. The new version can't handle old data. It'll be hard to deploy
label
Sep 3, 2024
VladLazar
force-pushed
the
vlad/storcon-make-ps-az-mandatory
branch
from
September 3, 2024 16:56
21d5ccb
to
2f78f1a
Compare
VladLazar
force-pushed
the
vlad/storcon-make-ps-az-mandatory
branch
from
September 3, 2024 17:12
a669b2c
to
2f78f1a
Compare
VladLazar
removed
the
backward compatibility breakage
Broken backward compatibility. The new version can't handle old data. It'll be hard to deploy
label
Sep 3, 2024
Need to merge https://github.com/neondatabase/cloud/pull/17191 on the cplane side for e2e tests to pass first. |
jcsp
reviewed
Sep 4, 2024
jcsp
approved these changes
Sep 4, 2024
VladLazar
force-pushed
the
vlad/storcon-make-ps-az-mandatory
branch
from
September 4, 2024 12:14
a7afeef
to
e10a76f
Compare
As of 2024-09-05 all nodes in all regions (apart from the azure region which I couldn't check) have AZs assigned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#8852 introduced a new nullable column for the
nodes
table:availability_zone_id
Summary of changes
This should roll out one deployment after #8852
and we should validate that there are no null entries for the
node.availability_zone_id
column.Note
This breaks the test_backward_compatibility test because the current release version of neon local
does not contain #8897. Hence, the migration to make the az id column not null fails.
In production we already have code that detects the az for pageservers and persists them upon registration.
I will merge this PR later into the week and check that all pageservers have persisted an az id.
Checklist before requesting a review
Checklist before merging