Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): add dry-run to force compact API #8859

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Aug 28, 2024

Problem

Looking at the logs after I ran compaction on some tenants, I realized that dry-run was never part of the API...

Summary of changes

Add dry-run flag to the compact API

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh skyzh requested review from problame and arpad-m August 28, 2024 19:08
@skyzh skyzh requested a review from a team as a code owner August 28, 2024 19:08
Copy link

3780 tests run: 3674 passed, 0 failed, 106 skipped (full report)


Flaky tests (1)

Postgres 14

Code coverage* (full report)

  • functions: 32.5% (7401 of 22748 functions)
  • lines: 50.7% (60060 of 118380 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8d2e953 at 2024-08-28T20:46:22.985Z :recycle:

@skyzh skyzh merged commit 18bfc43 into main Aug 29, 2024
69 checks passed
@skyzh skyzh deleted the skyzh/compact-dryrun-api branch August 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants