Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async_trait usages from safekeeper and neon_local #8864

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Aug 29, 2024

Removes additional async_trait usages from safekeeper and neon_local.

Also removes now redundant dependencies of the async_trait crate.

cc earlier work: #6305, #6464, #7303, #7342, #7212, #8296

@arpad-m arpad-m requested a review from arssher August 29, 2024 12:34
@arpad-m arpad-m requested a review from a team as a code owner August 29, 2024 12:34
Copy link

3801 tests run: 3695 passed, 0 failed, 106 skipped (full report)


Flaky tests (5)

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 32.5% (7413 of 22799 functions)
  • lines: 50.7% (60168 of 118671 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
83eaeae at 2024-08-29T14:08:13.522Z :recycle:

@arpad-m arpad-m merged commit 8eaa8ad into main Aug 29, 2024
67 checks passed
@arpad-m arpad-m deleted the arpad/remove_async_trait branch August 29, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants