Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: fix password hash cancellation #8868

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

conradludgate
Copy link
Contributor

In #8863 I replaced the threadpool with tokio tasks, but there was a behaviour I missed regarding cancellation. Adding the JoinHandle wrapper that triggers abort on drop should fix this.

Another change, any panics that occur in password hashing will be propagated through the resume_unwind functionality.

@conradludgate conradludgate requested a review from a team as a code owner August 29, 2024 16:39
@conradludgate conradludgate enabled auto-merge (squash) August 29, 2024 16:42
Copy link

github-actions bot commented Aug 29, 2024

4061 tests run: 3955 passed, 0 failed, 106 skipped (full report)


Flaky tests (11)

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 32.5% (7413 of 22809 functions)
  • lines: 50.6% (60048 of 118588 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
63d9e7c at 2024-08-29T19:21:30.788Z :recycle:

@conradludgate conradludgate merged commit 022fad6 into main Aug 29, 2024
69 checks passed
@conradludgate conradludgate deleted the proxy-password-cancellation branch August 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants