safekeeper: add endpoint resetting uploaded partial segment state. #8877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is used in many places, let's reduce number of ? on construction results.
arssher
requested review from
problame,
petuhovskiy and
VladLazar
and removed request for
problame
3815 tests run: 3709 passed, 0 failed, 106 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
0699bb8 at 2024-09-03T13:31:36.117Z :recycle: |
petuhovskiy
reviewed
Aug 30, 2024
petuhovskiy
reviewed
Aug 30, 2024
petuhovskiy
reviewed
Aug 30, 2024
petuhovskiy
reviewed
Aug 30, 2024
petuhovskiy
reviewed
Sep 2, 2024
arssher
force-pushed
the
sk-reset-backup-partial
branch
2 times, most recently
from
548b028 to
c010d44
Compare
petuhovskiy
reviewed
Sep 3, 2024
Endpoint implementation sends msg to manager requesting to do the reset. Manager stops current partial backup upload task if it exists and performs the reset. Also slightly tweak eviction condition: all full segments before flush_lsn must be uploaded (and committed) and there must be only one segment left on disk (partial). This allows to evict timelines which started not on the first segment and didn't fill the whole segment (previous condition wasn't good because last_removed_segno was 0). ref #8759
arssher
force-pushed
the
sk-reset-backup-partial
branch
from
c010d44 to
3d8b09b
Compare
Make all them snake case.
petuhovskiy
approved these changes
Sep 3, 2024
koivunej
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safekeeper: add endpoint resetting uploaded partial segment state.
Endpoint implementation sends msg to manager requesting to do the
reset. Manager stops current partial backup upload task if it exists and
performs the reset.
ref #8759