Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottommost-compaction: remove dead code / rectify cfg!()s #8884

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

problame
Copy link
Contributor

@problame problame commented Sep 2, 2024

part of #8002

@problame problame requested a review from a team as a code owner September 2, 2024 10:37
@problame problame requested review from VladLazar and skyzh and removed request for VladLazar September 2, 2024 10:37
Copy link

github-actions bot commented Sep 2, 2024

3808 tests run: 3702 passed, 0 failed, 106 skipped (full report)


Flaky tests (2)

Postgres 14

Code coverage* (full report)

  • functions: 32.4% (7412 of 22848 functions)
  • lines: 50.6% (60039 of 118676 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
21e0558 at 2024-09-02T13:43:49.958Z :recycle:

@skyzh
Copy link
Member

skyzh commented Sep 2, 2024

Code around finish will be changed in #8841 but approving it for now.

@problame problame merged commit 15e90cc into main Sep 2, 2024
67 checks passed
@problame problame deleted the problame/btmmost-compaction-remove-dead-code branch September 2, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants