-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: sync between benchies #8919
Conversation
3917 tests run: 3796 passed, 1 failed, 120 skipped (full report)Failures on Postgres 16
Flaky tests (6)Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
3072e37 at 2024-09-05T14:23:57.319Z :recycle: |
5ad05b9
to
7617274
Compare
Since the first run didn't fail but also didn't I think it would be best to merge this fast as soon as we have evidence of sync being run for a non-zero amount of time and see if it changes anything with the benches on Assuming the current run goes well, could @bayandin add a fix for the comment? Then, let's have a new run and merge. No failures with the third run either. |
Co-authored-by: Alexander Bayandin <alexander@neon.tech>
Sometimes, the benchmarks fail to start up pageserver in 10s without any obvious reason. Benchmarks run sequentially on otherwise idle runners. Try running
sync(2)
after each bench to force a cleaner slate.Implement this via:
Evidence: https://neon-github-public-dev.s3.amazonaws.com/reports/main/10678984691/index.html#suites/5008d72a1ba3c0d618a030a938fc035c/1210266507534c0f/