Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installation instructions for m4 on mac #8929

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

stradig
Copy link
Contributor

@stradig stradig commented Sep 5, 2024

Problem

Building on MacOS failed due to missing m4. Although a window was popping up claiming to install m4, this was not helping.

Summary of changes

Add instructions to install m4 using brew and link it (thanks to Folke for helping).

@arpad-m arpad-m requested review from problame and skyzh September 5, 2024 14:15
@stradig stradig marked this pull request as ready for review September 5, 2024 14:16
README.md Outdated Show resolved Hide resolved
@stradig
Copy link
Contributor Author

stradig commented Sep 5, 2024

Thanks, VS Code sometimes adds this :(. Fixed.

Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- @davidgomes also added this in one of his PR, anyways, we can get this merged first

@davidgomes
Copy link
Contributor

LGTM -- @davidgomes also added this in one of his PR, anyways, we can get this merged first

Just merge this, I will rebase and fix conflicts because my PR will take a while to get merged.

Copy link

github-actions bot commented Sep 5, 2024

3829 tests run: 3719 passed, 0 failed, 110 skipped (full report)


Flaky tests (2)

Postgres 16

Postgres 15

Code coverage* (full report)

  • functions: 31.9% (7389 of 23138 functions)
  • lines: 50.3% (59653 of 118607 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
02412e4 at 2024-09-05T15:16:28.966Z :recycle:

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m4 comes with command line tools (CLT, installed via xcode-select --install), @stradig / @davidgomes could you guys share your brew config output (it shows which CLT version is installed)

@bayandin bayandin dismissed their stale review September 5, 2024 15:31

Don't want to block the merge

@davidgomes
Copy link
Contributor

m4 comes with command line tools (CLT, installed via xcode-select --install), @stradig / @davidgomes could you guys share your brew config output (it shows which CLT version is installed)

It didn't for me, for sure. Anyway, here's my brew config output:

HOMEBREW_VERSION: 4.3.19
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1f9bd2de89883ec9a59db3eab0f5475bce06d5bc
Last commit: 3 days ago
Core tap JSON: 05 Sep 14:13 UTC
Core cask tap JSON: 05 Sep 14:13 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 11
Homebrew Ruby: 3.3.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/bin/ruby
CPU: 11-core 64-bit arm_lobos
Clang: 15.0.0 build 1500
Git: 2.45.2 => /opt/homebrew/bin/git
Curl: 8.6.0 => /usr/bin/curl
macOS: 14.5-arm64
CLT: 15.3.0.0.1.1708646388
Xcode: N/A
Rosetta 2: false

@cloneable
Copy link
Contributor

cloneable commented Sep 5, 2024

m4 comes with command line tools (CLT, installed via xcode-select --install), @stradig / @davidgomes could you guys share your brew config output (it shows which CLT version is installed)

No, it's a known issue for a few months now and Apple is working on a fix supposedly. https://github.com/Homebrew/homebrew-core/issues/165388#issuecomment-2029794821

@stradig
Copy link
Contributor Author

stradig commented Sep 5, 2024

Thanks!

Here is my output

HOMEBREW_VERSION: 4.3.19
ORIGIN: https://github.com/Homebrew/brew
HEAD: 1f9bd2de89883ec9a59db3eab0f5475bce06d5bc
Last commit: 3 days ago
Core tap JSON: 05 Sep 13:16 UTC
Core cask tap JSON: 05 Sep 13:16 UTC
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 12
Homebrew Ruby: 3.3.4 => /opt/homebrew/Library/Homebrew/vendor/portable-ruby/3.3.4_1/bin/ruby
CPU: dodeca-core 64-bit arm_lobos
Clang: 15.0.0 build 1500
Git: 2.39.3 => /Library/Developer/CommandLineTools/usr/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 14.6.1-arm64
CLT: 15.3.0.0.1.1708646388
Xcode: N/A
Rosetta 2: false

@stradig stradig merged commit fd12dd9 into main Sep 5, 2024
67 checks passed
@stradig stradig deleted the stefan/mac-build-include-m4-install branch September 5, 2024 15:48
@bayandin
Copy link
Member

bayandin commented Sep 5, 2024

m4 comes with command line tools (CLT, installed via xcode-select --install), @stradig / @davidgomes could you guys share your brew config output (it shows which CLT version is installed)

No, it's a known issue for a few months now and Apple is working on a fix supposedly. https://github.com/Homebrew/homebrew-core/issues/165388#issuecomment-2029794821 I wonder if they initially did that because of M4 branding.

Thanks for the link!
My knowledge was outdated 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants